Thanks Nicholas, I appreciate you taking the time to comment. I have adjusted the code to dispose of the outer property, thankfully using middleware it’s easy to surround the call to the next piece of middleware with a using statement.

Also thanks for giving the community Serilog, it is an excellent product.

Darren

There’s one gotcha I think this approach might hit; LogContext needs to be “popped” again by disposing the object that’s returned from it, otherwise there’s the potential for space leaks (*not always).

E.g.:

var pushed = LogContext.PushProperty("Shop", siteAccessDetails.ShopName);
// Log things, then...
pushed.Dispose();

The * is because only the “outermost” property needs to be popped off, to remove any that were pushed on top of it, so you should be able to do this with only one IDisposable tracked.

There’s also a PushProperties() method that can accept multiple PropertyEnricher objects in a single call, which may simplify the “popping” aspect.

Cheers!